Migrated components to Typescript #1806
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 flaky test on run #4682 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Hash Links > on Corporate Sponsorship page > will change route when clicked |
Screenshots
Video
|
|
Review all test suite changes for PR #1806 ↗︎
|
Code Climate has analyzed commit eb83f1a and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 63.5% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.3% (0.0% change). View more on Code Climate. |
| @@ -0,0 +1,2 @@ | |||
| export const objectKeys = <Type extends object>(value: Type) => | |||
There was a problem hiding this comment.
oh you could increase coverage by either ignoring this file or adding a unit test for it.
it's literally 2 lines though so it wouldn't be a big bump 😂
There was a problem hiding this comment.
Do you typically ignore a file like that, or is the convention to create a test for it?
There was a problem hiding this comment.
I mean it's a pretty basic function created solely for a typing DX improvement. I'm not very worried about it.
Description of changes
Migrated the following components to Typescript, removed prop-types, and added a props type:
Nav-
NavListItem-
NavMobileOutboudLinkPaginationPaginationItemPartnerLogoLinkPressPressLinksPressPhotosPressVideosProgressIndicatorMigrating components included all test and storybook files for each.
Issue Resolved
Fixes #NA
Screenshots/GIFs