Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in v5.2.0 label for all new features #1406

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 25, 2022

Add an 'Added in v5.2.0' label for all of our new features.

Please check that nothing's missing (see #846 as reference).

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Jul 25, 2022
@julien-deramond julien-deramond added this to In progress in v5.2.0 via automation Jul 25, 2022
@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1ae4cde
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62de7858da0b460009eeed6c
😎 Deploy Preview https://deploy-preview-1406--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if the added-in should be on top of the page in orange-navbar.md.
In carousel.md, add a tag for play/pause button. (and add it in ship list ?)
In check-radios.md, add a tag for without labels part ?
In borders.md, add a tag for variables ? (maybe on Bs)
Do we need to add a tag on dark-offcanvas ? (on Bs side ?)

EDIT: masthead.html doesn't have the same code but it might not be an issue

@julien-deramond
Copy link
Member Author

julien-deramond commented Jul 25, 2022

Wondering if the added-in should be on top of the page in orange-navbar.md. In carousel.md, add a tag for play/pause button. (and add it in ship list ?) In check-radios.md, add a tag for without labels part ? In borders.md, add a tag for variables ? (maybe on Bs) Do we need to add a tag on dark-offcanvas ? (on Bs side ?)

EDIT: masthead.html doesn't have the same code but it might not be an issue

  • Orange Navbar didn't exist in v5.1.3 so it must be on top of the page
  • Carousel with pause/play button. Good catch! Added in 9671024 (also in the ship list, IDK why it wasn't there)
  • Check & Radios without labels comes from Bootstrap so let's let it as it is
  • Same thing for Borders CSS variables (Bootstrap)
  • Same thing for Dark OffCanvas (Bootstrap)

@julien-deramond julien-deramond merged commit cf20110 into main Jul 25, 2022
@julien-deramond julien-deramond deleted the main-jd-add-v5.2.0-labels branch July 25, 2022 11:12
v5.2.0 automation moved this from In progress to Done Jul 25, 2022
@julien-deramond julien-deramond mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants