Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar: Increase size of links hitbox #1691

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Navbar: Increase size of links hitbox #1691

wants to merge 10 commits into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 7, 2022 •
edited

Related issues

Fixes #1690.
Fixes #1194.

Description

Add a hitbox and margin to links to better the focus state of navbars.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit aa3c149
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596b4c4e56636000994052b
😎 Deploy Preview https://deploy-preview-1691--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton mentioned this pull request Feb 13, 2023
Open
@louismaximepiton louismaximepiton marked this pull request as ready for review March 9, 2023 15:42
@MewenLeHo MewenLeHo self-requested a review March 13, 2023 15:55
MewenLeHo
MewenLeHo reviewed Mar 13, 2023
View reviewed changes
scss/_navbar.scss Outdated Show resolved Hide resolved
MewenLeHo
MewenLeHo reviewed Mar 13, 2023
View reviewed changes
scss/_navbar.scss Outdated Show resolved Hide resolved
MewenLeHo
MewenLeHo approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it will be better for focus so ok for me.

@B3nz01d B3nz01d added this to Design & Accessibility Review in 🟣 PR Board (Draft) Mar 29, 2023
@Franco-Riccitelli
Copy link

All looks good to me. No issues.

@Aniort Aniort self-requested a review April 11, 2023 09:03
Aniort
Aniort approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go on!

@louismaximepiton louismaximepiton moved this from Need Design &/or Accessibility Review to Need Lead Dev Review in 🟣 PR Board (Draft) Apr 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louismaximepiton louismaximepiton mentioned this pull request Mar 5, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond left review comments

@Aniort Aniort Aniort approved these changes

@MewenLeHo MewenLeHo MewenLeHo approved these changes

Assignees
No one assigned
Labels
accessibility enhancement passed a11y review passed design review v5
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Status: Need Lead Dev Review
🟣 PR Board (Draft)
Need Lead Dev Review
Milestone
No milestone
5 participants
@louismaximepiton @Franco-Riccitelli @Aniort @julien-deramond @MewenLeHo