Examples: new app download page #1915
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
some links to update in the page:
|
louismaximepiton
moved this from In progress / Draft
to Need Dev Review
in 🟣 PR Board (Draft)
julien-deramond
moved this from Need Design &/or Accessibility Review
to Need Lead Dev Review
in 🟣 PR Board (Draft)
|
@louismaximepiton There's probably something missing (to double-check). $ npm run release
$ unzip boosted-5.3.0-alpha3-examples.zip
$ cd boosted-5.3.0-alpha3-examples
$ php -S localhost:8008 # or something equivalent |
|
Tried it and the images seem to be recognized and copied. However, it seems that there's an issue with additional CSS and Boosted Js at least. |
|
Kudos, SonarCloud Quality Gate passed!
|
| const toggle = document | ||
| .createRange() | ||
| .createContextualFragment( | ||
| `<div class="form-check form-switch my-2 my-lg-0"><input class="form-check-input ms-0" type="checkbox" id="mastermediaAllowed" aria-describedby="tacCLmastermedia" onchange="${choiceEvent}"${((document.cookie.match(/^(?:.*;)?\s*cookie-consent\s*=\s*([^;]+)(?:.*)?$/) || [null])[1].match('!mastermedia=true') ? 'checked' : '')}><label class="form-check-label visually-hidden" for="mastermediaAllowed">Google Tag Manager</label><input id="mastermediaDenied" class="d-none"></div>` |
There was a problem hiding this comment.
"Google Tag Manager" should prolly be changed
| {{- if eq .Page.Title "Download app" -}} | ||
| {{- $vendor := resources.Match "js/vendor/*.js" -}} | ||
| {{- $js := resources.Match "js/*.js" -}} | ||
| {{- $targetDocsJSPath := path.Join "/docs" .Site.Params.docs_version "assets/js/docs.js" -}} |
There was a problem hiding this comment.
We should probably split docs.js as we did for docs.css
|
All comments have been taken into account. Apparently, there are no more Mastermedia cookies, or we dreamt there were Mastermedia cookies at some point. So we close this PR which is now superseded by #2146 |
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Closes #1888.
Description
Adding a new example page to show how to make a download page for apps.
Dev questions:
.border-translucentto Bootstrap directly ?Motivation & Context
To help people download our apps.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge