Pagination: responsive part round 2 #1931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewenLeHo
reviewed
Apr 4, 2023
MewenLeHo
reviewed
Apr 4, 2023
louismaximepiton
added this to In progress
in 🟣 Sprint 20 - April/May 2023
via automation
louismaximepiton
moved this from In progress
to In review
in 🟣 Sprint 20 - April/May 2023
🟣 PR Board (Draft)
automation
moved this from Need Dev Review
to Need Design &/or Accessibility Review
Apr 18, 2023
louismaximepiton
added
ready for a11y review
ready for design review
and removed
upcoming a11y review
upcoming design review
labels
Aniort
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
As @MewenLeHo says, there content conveying info display via CSS (< and >) it's a n issue
add a real icon with an aria-hidden=true
2 tasks
|
Will be taken into account with #2008. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
The third example for pagination Responsive behaviour looks and behaves as specified. No issues. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Superseed #1370.
Description
Add something to handle the mobile responsive part
Motivation & Context
Follow the Orange brand.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
:notbut already used almost everywhere and should be supported by all browser, I might have done something wrong in here. (https://developer.mozilla.org/en-US/docs/Web/CSS/:not#browser_compatibility)After the merge