Chore merge from c5f46b0 to 6d24ccc #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
louismaximepiton
requested changes
Jul 24, 2023
| @@ -220,17 +220,18 @@ | |||
|
|
|||
| // scss-docs-start custom-tooltip | |||
| .custom-tooltip { | |||
| --bs-tooltip-bg: var(--bs-primary); | |||
| --bs-tooltip-bg: var(--bd-violet-bg); | |||
There was a problem hiding this comment.
[Bootstrap side] It feels weird to have a reference to bd- inside our doc.
| } | ||
| // scss-docs-end custom-tooltip | ||
|
|
||
| // scss-docs-start custom-popovers | ||
| .custom-popover { | ||
| --bs-popover-max-width: 12.5rem; | ||
| --bs-popover-border-color: var(--bs-primary); | ||
| --bs-popover-border-color: var(--bd-violet-bg); | ||
| --bs-popover-header-bg: var(--bd-violet-bg); |
There was a problem hiding this comment.
[Bootstrap side] It feels weird to have a reference to bd- inside our doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twbs/bootstrap@9cc85fd: nothing to do since we don't have these vars in Boostedtwbs/bootstrap@7a42268: can't regerenatepackage-lock.jsonnow since some packages will be updated later on in this PR--bd-primary-*Boosted-specific to handle the various container colors in the documentation to be orange and not violet.twbs/bootstrap@a70852f: this example doesn't exist in Boosted