New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags #988
Tags #988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, here are my comments, feel free to ask or discuss about it.
I think it is in contradiction to what Gaël said, but I think you should avoid reference to .badge
since you don't have anything more in common with those.
I would avoid px
and em
values by replacing them with rem
.
I think that dark version of this component can be handled later (or now if you want to), once the normal version is fully developed.
This comment was marked as outdated.
This comment was marked as outdated.
be9098b
to
2988f53
Compare
78fdae3
to
ee269e4
Compare
FYI @louismaximepiton I've changed the added-in shortcode via 542fc41 in order to use the tags. I chose the small version. |
0a8a7c3
to
8218135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 🚀 🎉
Closes #552
All states and use-cases are implemented.
New PR from old PR #666
Live previews