Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags #988

Merged
merged 38 commits into from Oct 20, 2022
Merged

Tags #988

merged 38 commits into from Oct 20, 2022

Conversation

vogloblinsky
Copy link
Contributor

@vogloblinsky vogloblinsky commented Dec 20, 2021

Closes #552

All states and use-cases are implemented.

New PR from old PR #666

Live previews

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, here are my comments, feel free to ask or discuss about it.

I think it is in contradiction to what Gaël said, but I think you should avoid reference to .badge since you don't have anything more in common with those.
I would avoid px and em values by replacing them with rem.
I think that dark version of this component can be handled later (or now if you want to), once the normal version is fully developed.

scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
scss/_tag.scss Outdated Show resolved Hide resolved
site/content/docs/5.1/components/tags.md Outdated Show resolved Hide resolved
site/content/docs/5.1/components/tags.md Outdated Show resolved Hide resolved
site/content/docs/5.1/components/tags.md Outdated Show resolved Hide resolved
@louismaximepiton

This comment was marked as outdated.

@julien-deramond
Copy link
Member

FYI @louismaximepiton I've changed the added-in shortcode via 542fc41 in order to use the tags. I chose the small version.
I haven't followed all conversations around the design of tags, but we should have a non-clickable version of them.

@louismaximepiton louismaximepiton marked this pull request as ready for review April 19, 2022 16:51
scss/_tag.scss Outdated Show resolved Hide resolved
@louismaximepiton
Copy link
Member

FYI, tags with a different svg can be built:

<span class="tag">
  <svg viewBox="0 0 20 20" width="1.5rem" height="1.5rem" aria-hidden="true" focusable="false">
    <circle cx="10" cy="10" r="9" stroke-width="2" stroke="#000" fill="#f00" />
  </svg>
  Red
</span>

renders like:

image

scss/_tag.scss Outdated Show resolved Hide resolved
site/content/docs/5.2/components/tags.md Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/tags/index.html Outdated Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/_tags.scss Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/_tags.scss Outdated Show resolved Hide resolved
scss/forms/_form-check.scss Outdated Show resolved Hide resolved
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal to improve the documentation: 19d6711

Proposal to enhance the example page: 264c594

site/content/docs/5.2/components/tags.md Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀 🎉

@julien-deramond julien-deramond merged commit a163d5d into main Oct 20, 2022
@julien-deramond julien-deramond deleted the feat-tags branch October 20, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation > Tags
6 participants