Add formatting guidelines #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched from the wrong branch into a new one, oops. |
sreekaransrinath
force-pushed
the
add-formatting-guidelines
branch
from
975065d
to
dc5610f
Compare
SirusCodes
requested changes
Oct 26, 2022
| @@ -18,6 +18,8 @@ | |||
| - Write meaningful commit messages and include the number (`#`) of the issue being resolved (if any) at the end of the commit message. | |||
|
|
|||
| Example: `:bug: fix: Resolve 'isCorrect' function error (#0)` | |||
|
|
|||
| - Format your code with [Prettier](https://prettier.io/), and set "printWidth" to 80. | |||
There was a problem hiding this comment.
Can you add the command as well to run it?
There was a problem hiding this comment.
- Also, I don't think mentioning the 'print width' is necessary, because if the extension is installed in let's say VS Code, the
.prettierrcfile in the project will automatically override the user's local settings. - The trailing
/in the URL is unnecessary and should be removed IMO.
There was a problem hiding this comment.
How I had referred to Prettier in previous projects: github.com/HarshKapadia2/git_internals/blob/main/CONTRIBUTING.md
HarshKapadia2
requested changes
Oct 26, 2022
| @@ -18,6 +18,8 @@ | |||
| - Write meaningful commit messages and include the number (`#`) of the issue being resolved (if any) at the end of the commit message. | |||
|
|
|||
| Example: `:bug: fix: Resolve 'isCorrect' function error (#0)` | |||
|
|
|||
| - Format your code with [Prettier](https://prettier.io/), and set "printWidth" to 80. | |||
There was a problem hiding this comment.
- Also, I don't think mentioning the 'print width' is necessary, because if the extension is installed in let's say VS Code, the
.prettierrcfile in the project will automatically override the user's local settings. - The trailing
/in the URL is unnecessary and should be removed IMO.
| @@ -18,6 +18,8 @@ | |||
| - Write meaningful commit messages and include the number (`#`) of the issue being resolved (if any) at the end of the commit message. | |||
|
|
|||
| Example: `:bug: fix: Resolve 'isCorrect' function error (#0)` | |||
|
|
|||
| - Format your code with [Prettier](https://prettier.io/), and set "printWidth" to 80. | |||
There was a problem hiding this comment.
How I had referred to Prettier in previous projects: github.com/HarshKapadia2/git_internals/blob/main/CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10