Add possibility in verify view for HD wallets to choose the address format #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributions. I will be looking into them this week with the possibility of merging after. Sorry again for the delay in responding. |
|
@ok2 this is awesome and works flawless! is it possible for you to add BCH support with the latest Btw is there any chance that I can get in touch with you privately? Regards Zilveer |
|
@ok2 can you please reply whether or not it is possible for you to add BCH support? /Best regards Zilveer |
|
Yes
209 3024708
Or
6292281236
Jesus V Guerrero
You can text
Or call
Thank you
…On Tue, May 9, 2023, 4:16 PM zilveer ***@***.***> wrote:
@ok2 <https://github.com/ok2> this is awesome and works flawless!
is it possible for you to add BCH support with the latest q addresses as
well as signing a transaction?
Btw is there any chance that I can get in touch with you privately?
Regards Zilveer
—
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7FZPFFWGGK2DXAEIRSDC3XFLF4NANCNFSM42NEAQCA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Yes but I don't know how I need to be walked threw it
…On Fri, Jun 2, 2023, 1:55 PM J G ***@***.***> wrote:
Yes
209 3024708
Or
6292281236
Jesus V Guerrero
You can text
Or call
Thank you
On Tue, May 9, 2023, 4:16 PM zilveer ***@***.***> wrote:
> @ok2 <https://github.com/ok2> this is awesome and works flawless!
>
> is it possible for you to add BCH support with the latest q addresses as
> well as signing a transaction?
>
> Btw is there any chance that I can get in touch with you privately?
>
> Regards Zilveer
>
> —
> Reply to this email directly, view it on GitHub
> <#230 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AG7FZPFFWGGK2DXAEIRSDC3XFLF4NANCNFSM42NEAQCA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
|
2093024708
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to choose the address format for generated HD wallet addresses in verify view. Together with #228 and #229 it is now possible to generate the same wallet in coinb.in and bitcoin core and recreate in coinb.in the same addresses.