Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-4896: Fix child dropdown being erased when using ApplyRowValidations #412

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

ROU-4896: Fix child dropdown being erased when using ApplyRowValidations #412

wants to merge 1 commit into from

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is to fix the child dropdown being erased when using ApplyRowValidations.

What was happening

  • When using the ApplyRowValidations Client Action in a Grid with Dropdown Dependency, the child dropdown cell was being erased
  • This happened because the ApplyRowValidations triggers the OnCellValueChange event of the Column and the Dropdown Column's _parentCellValueChangeHandler method was not considering this scenario.

What was done

  • Added a flag to check when the ApplyRowValidations API triggered the OnCellValueChange event and validate if it should erase the child dropdown value or not.

Test Steps

  1. Go to a page with a Grid with Dropdown Dependency
  2. Run the ApplyRowValidations Client Action
  3. Check that no cells were erased
  4. Check that the OnCellValueChange was triggered once for each column

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner May 7, 2024 16:43
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label May 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@OS-giulianasilva