Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49 peppol lookup dummylookupclient implementation #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dladlk
Copy link

@dladlk dladlk commented Jun 5, 2023

Pull Request Description

Please include a summary of the change request or bug which is supposed to be fixed as part of this pull request

Type of Pull Request

  • New feature/Enhancement - non-breaking change which adds functionality
  • Bug fix
  • Breaking change (Require Major version change?)

Type of Change

  • OpenPeppol AS2/AS4 specification
  • OpenPeppol Spring/Fall release
  • Oxalis software change or enhancement
  • CEF change

Pull Request Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas. But did not added unnecessary annotation/comment say @author name etc
  • I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new/additional warnings
  • My change is not breaking or creating conflict with associated dependencies
  • I have performed a self-review of my own code
  • I ran mvn clean install before commit and all tests run successfully
  • I conducted basic QA to assure all features are working fine
  • My pull request generate no conflicts with master branch
  • I requested code review from other team members

@dladlk dladlk linked an issue Jun 5, 2023 that may be closed by this pull request
@dladlk dladlk requested a review from aaron-kumar June 5, 2023 11:15
@aaron-kumar aaron-kumar added this to the 7.x.x milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Future
Development

Successfully merging this pull request may close these issues.

peppol-lookup: DummyLookupClient implementation
2 participants