Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to change PhpUnit ExpectedExceptionMessageRegExp #4924

Closed
wants to merge 1 commit into from
Closed

Add rule to change PhpUnit ExpectedExceptionMessageRegExp #4924

wants to merge 1 commit into from

Conversation

soyuka
Copy link

@soyuka soyuka commented Apr 16, 2020

As of phpunit 8 expectExceptionMessageRegExp is deprecated

Related issues: sebastianbergmann/phpunit#4133, symfony/symfony#36408

Let me know if there's a way to test that old versions of phpunit won't be affected by this rule.

@kubawerlos
Copy link
Contributor

Wouldn't extending PhpUnitExpectationFixer be better (less code and no introducing new fixer) approach?

@keradus keradus changed the base branch from 2.16 to 2.17 December 17, 2020 13:43
@keradus keradus changed the base branch from 2.17 to master January 24, 2021 21:38
@SpacePossum
Copy link
Contributor

Thanks @soyuka for opening this PR and by that bringing this to our attention.
I think handling this case was added in #4908 and as such this PR can be closed, however I might misread things.

@julienfalque
Copy link
Member

Indeed, this was implemented in #4908. Thanks anyway @soyuka for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soyuka @kubawerlos @SpacePossum @julienfalque