feat: Add assertResponseStatusCodeSame to StaticMethodCallsFixer

[MarlonResler]

Add assertResponseStatusCodeSame to PhpUnitTestCaseStaticMethodCallsFixerTest.php.
Referencing Feature Request:
#7922

The change is already covered by test for this file imho.

[coveralls]

coverage: 96.013%. remained the same
when pulling ca32c76 on MarlonResler:feature/assertResponseStatusCodeSame-to-StaticMethodCallsFixer
into ce40b80 on PHP-CS-Fixer:master.

[kubawerlos]

Referencing Feature Request: #7922

No, not really, that feature request mentions assertResponseStatusCodeSame as an example, there are more Symfony's assertions: https://symfony.com/doc/current/testing.html#response-assertions

The change is already covered by test for this file IMHO.

How is that? Change covered by a test is a change that when reverted that test would fail.

[Wirone]

Hi @MarlonResler and thanks for your contribution! Unfortunately, as @kubawerlos already pointed out, this PR neither addresses #7922 (which is about flexible way for defining assertions that should be fixed, assertResponseStatusCodeSame is only an example), or is covered by tests (the STATIC_METHODS constant you extended is only referenced in testFixerContainsAllPhpunitStaticMethodsInItsList() which only verifies if we have all the assert methods on our list). In this form your PR does not follow our contribution guide, and can't be merged. Adding test for this one particular method also is not a way we should go, as this does not solve the root issue. Are you willing to implement full support for flexible list of assertion methods 🙂?

Side note: mentioned test that uses STATIC_METHODS is pretty weird, as TestCase differs between PHPUnit versions and list of assertions is not the same for them. Also, it checks if we have every assertion method on our list, but does not check if we have more than that, and as far as I see for example assertArraySubset was deprecated and removed, but it's still on our list. Should we clean this up, or should this list be historically filled with all assertions that were available? 🤔

[MarlonResler]

Hi @Wirone,
I see I misinterpreted the test you mentioned in the class as a full test, just as I overlooked the example in the feature request I mentioned.
The change resulted from a local workaround that I didn't look at closely enough.
Since a customizable list of asserts was desired by the feature request and this makes sense in conjunction with other frameworks, I'll take a closer look at it the next days.