Support ffprobe frames and additional options #686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds a new api method to retrieve frames through ffprobe
It also adds a support for additional options allowing more custom calls
As an addition, as
last
method has been added toStreamCollection
andFrameCollection
for easier retrievalI also regenerated the api doc which was largely outdated, using sami 1.4.1, feel free to hide this commit to make the review easier
Why?
Frames information can be needed in some cases (see example below)
Additional options allow some filtering directly within ffprobe which would otherwise require iteration and operations on our output and therefore defeat the purpose ffprobe having such features
Example Usage
Retrieving the starting byte and ending byte matching a timestamp interval in an audio file (needed to generate audio previews without persistence)
Backward compatibility
No BC break.
Interfaces are left unmodified and public api methods only offer a new parameter with a default value not altering the behavior in any way
Unit tests have been updated accordingly