additionalParameters capability in audio formats #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added get and set functions for additionalParameters in Format\Audio\DefaultAudio.php and included the new additionalParameters variable to be included in the build function in Media\Audio.php
deluxetom
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
My first time creating a pull request on github so please go easy on me :-D Apologies for anything i might have not gotten right.
What's in this PR?
I have added get and set functions for additionalParameters in Format\Audio\DefaultAudio.php and included the new additionalParameters variable to be included in the build function in Media\Audio.php
Why?
Which problem does the PR fix?
I was trying to perform HLS encoding of an audio (mp3) file which requires me to set up some additional command line switches (additional parameters). I figured out I could set them in a video format (any formats inherited from the DefaultVideo) but not audio formats (any formats inherited from the DefaultAudio class)
To Do
Have not created any tests.