Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffprobe streams additional commands #797

Open
wants to merge 89 commits into
base: master
Choose a base branch
from
Open

Ffprobe streams additional commands #797

wants to merge 89 commits into from

Conversation

vietnguyen09
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

ffprobe streams commands need to pass dynamically!

Why?

Some of the HLS streams requires -referer command, but the ffprobe streams from $video->open($url) is using only $this->ffprobe->streams($pathfile)

Example Usage

$video = $ffmpeg->open($url);

// Now we can do
$video = $ffmpeg->open($url, ['-referer', 'some_url']);

jens1o and others added 30 commits November 8, 2017 14:40
Revert "Fix more tests in PHPUnit 6"
Use fluent interface when defining mocks
pralhadstha and others added 28 commits May 7, 2018 22:06
I missed to update the cache keys checked in the test to check whether the cache is working as intended
@vietnguyen09 vietnguyen09 changed the title V1 Ffprobe streams additional commands Feb 20, 2021
@Romain
Copy link
Member

Romain commented Mar 2, 2021

Hi @vietnguyen09 , could you resolve the conflicts first, in order for us to review it?
I'm not sure though why you've got all these commits listed in your history... This will make reviewing your PR pretty difficult...
We'll figure out after the conflicts are resolved if this is reviewable, otherwise, you'll have to create a clean PR with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants