Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Verify the
installed_paths
after save
As most problems reported are to do with paths not being set correctly, let's verify success within the plugin, independently of PHPCS. To that end, a new function `verifySaveSuccess()` has been added. This function takes the paths which were to be saved and compares then to the paths which are actually set in PHPCS after the save to determine whether or not the plugin was successful and changes the exit code if this is not the case. Open questions: * Should additional debug output be generated by the verification function when `verbose` mode is turned on ? Something like `Expected paths to be set to: %s, found: %s`. This could also come in handy to verify that all paths which should be set were found by the plugin. At this moment I don't have a test case for this new functionality, however, I imagine it will come in useful with future bug reports.
- Loading branch information