Skip to content

Commit

Permalink
GH Actions: set error reporting to E_ALL
Browse files Browse the repository at this point in the history
Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`.

For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown.
  • Loading branch information
jrfnl committed Jun 21, 2021
1 parent 52d2c44 commit 49a4e7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/integrationtest.yml
Expand Up @@ -140,6 +140,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: error_reporting=E_ALL, display_errors=On
coverage: none

- name: 'Composer: set PHPCS version for tests'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/quicktest.yml
Expand Up @@ -45,6 +45,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: error_reporting=E_ALL, display_errors=On
coverage: none

- name: 'Composer: set PHPCS version for tests'
Expand Down

0 comments on commit 49a4e7b

Please sign in to comment.