Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #103 #104

Merged
merged 2 commits into from Jan 27, 2020
Merged

Fix for issue #103 #104

merged 2 commits into from Jan 27, 2020

Commits on Jan 26, 2020

  1. Fix for issue PHPCSStandards#103 

    If the phpcodesniffer-composer-installer plugin is installed as a dev
requirement and it is then uninstalled as part of a "--no-dev" install, a bug
occurs. The bug that occurs is that the plugin complains that the  package
"squizlabs/php_codesniffer" is not installed without checking if the package
should be present.

This commit adds a check to verify that this plugin is actually installed before
complaining about the missing package. If this plugin itself is removed, then
it should not complain about the missing package.
    @Potherca
    Potherca committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    dc6d0e2 View commit details
    Browse the repository at this point in the history

  2. Change "is plugin uninstalled?" check to always run 

    Previously the check would only run if the plugin was require-dev.
That behaviour is incorrect, as the check should always be done.
If the plugin is not installed, it doesn't make sense to return an
error under any circumstances.

This commit fixes that oversight.
    @Potherca
    Potherca committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    8a008d5 View commit details
    Browse the repository at this point in the history