Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize a condition #127

Merged
merged 1 commit into from Dec 8, 2020
Merged

Commits on Dec 7, 2020

  1. Stabilize a condition

    While looking into the race condition described in 125, I noticed a potentially related issue.
    
    As per the documentation of [realpath()](https://www.php.net/manual/en/function.realpath.php#refsect1-function.realpath-returnvalues):
    > realpath() returns FALSE on failure, e.g. if the file does not exist.
    
    In the rare case that `realpath()` _would_ return `false` within this plugin, `false` would subsequently be passed on to `is_dir()` and `is_readable()` which both expect a string path.
    
    This tiny change make the condition fail earlier by checking the return value of `realpath()`.
    jrfnl committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    50b2f26 View commit details
    Browse the repository at this point in the history