Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mention of Composer and PHP compatibility to project README. #132

Merged
merged 2 commits into from Jun 13, 2021
Merged

Add mention of Composer and PHP compatibility to project README. #132

merged 2 commits into from Jun 13, 2021

Conversation

Potherca
Copy link
Member

Fixes #129

@Potherca Potherca requested a review from jrfnl January 31, 2021 11:20
@Potherca Potherca self-assigned this Jan 31, 2021
@Potherca Potherca mentioned this pull request Jan 31, 2021
Closed
jrfnl
jrfnl reviewed Mar 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Potherca
Copy link
Member Author

@jrfnl I finally found some time to update this! 🎉

I've changed the wording, as you suggested. Some things to note:

  • I added links to various things, just in case people want to know more
  • I placed the comment in a block (using >) to make it similar to the warning block further down in the document
  • I added an emoji as icon for the block, to make it stand out more (and look similar to the other block). I didn't feel this message warranted a "warning", so I opted for "Information" instead.

@Potherca Potherca requested a review from jrfnl June 13, 2021 11:13
jrfnl
jrfnl reviewed Jun 13, 2021
View reviewed changes
README.md

This plugin is compatible with:

- PHP **5.x**, **7.x**, and **8.x** (Support for PHP v8 is available since [`v0.7.0`][v0.7])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just placing a note here for the record:
While we currently can only guarantee support with PHP 8.0, the current test build against PHP 8.1 does seem to pass, so I'm fine with leaving this at v8.

@jrfnl jrfnl merged commit ce4370e into PHPCSStandards:master Jun 13, 2021
@Potherca Potherca deleted the issues/129-compatibility branch June 14, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees

@Potherca Potherca

Labels
documentation
Projects
None yet
Milestone
Release v0.7.2
Development

Successfully merging this pull request may close these issues.

Plugin is [NOT] incompatible with PHP 8
2 participants
@Potherca @jrfnl