Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 5.3 #147

Merged
merged 1 commit into from Mar 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/integrationtest.yml
Expand Up @@ -29,7 +29,7 @@ jobs:

include:
# Ensure a "highest" PHP/PHPCS build combination for PHPCS 2.x is included.
- php: '5.3'
- php: '5.4'
phpcs_version: '2.9.2'
phpcompat: 'composer'
experimental: false
Expand Down Expand Up @@ -81,10 +81,6 @@ jobs:
phpcs_version: '2.0.0'
phpcompat: '^7.0'
experimental: false
- php: '5.3'
phpcs_version: '2.0.0'
phpcompat: '^7.0'
experimental: false

# Additional builds against arbitrary interim PHPCS versions.
- php: '7.3'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/phplint.yml
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
php: ['5.3', '5.6', '7.2', 'latest']
php: ['5.4', '5.6', '7.2', 'latest']

name: "PHP Lint: PHP ${{ matrix.php }}"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/quicktest.yml
Expand Up @@ -37,7 +37,7 @@ jobs:
- php: '5.6'
phpcs_version: '2.6.0'
phpcompat: 'composer'
- php: '5.3'
- php: '5.4'
phpcs_version: '2.0.0'
phpcompat: '^7.0'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/securitycheck.yml
Expand Up @@ -21,7 +21,7 @@ jobs:

strategy:
matrix:
php: ['5.3', 'latest']
php: ['5.4', 'latest']

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -49,7 +49,7 @@ That's it.

This plugin is compatible with:

- PHP **5.x**, **7.x**, and **8.x** (Support for PHP v8 is available since [`v0.7.0`][v0.7])
- PHP **5.4+**, **7.x**, and **8.x** (Support for PHP v8 is available since [`v0.7.0`][v0.7])
- [Composer][composer] **1.x** and **2.x** (Support for Composer v2 is available since [`v0.7.0`][v0.7])
- [PHP_CodeSniffer][codesniffer] **2.x** and **3.x** (Support for PHP_CodeSniffer v3 is available since [`v0.4.0`][v0.4])

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -23,7 +23,7 @@
"source": "https://github.com/dealerdirect/phpcodesniffer-composer-installer"
},
"require": {
"php": ">=5.3",
"php": ">=5.4",
"composer-plugin-api": "^1.0 || ^2.0",
"squizlabs/php_codesniffer": "^2.0 || ^3.0 || ^4.0"
},
Expand Down
4 changes: 2 additions & 2 deletions phpcs.xml.dist
Expand Up @@ -13,10 +13,10 @@
<exclude-pattern>*/vendor/*</exclude-pattern>

<rule ref="PHPCompatibility"/>
<config name="testVersion" value="5.3-"/>
<config name="testVersion" value="5.4-"/>

<rule ref="PSR12">
<!-- Constant visibility can not be declared (yet) as the minimum supported PHP version is 5.3
<!-- Constant visibility can not be declared (yet) as the minimum supported PHP version is 5.4
and constant visibility was only introduced in PHP 7.1. -->
<exclude name="PSR12.Properties.ConstantVisibility.NotFound"/>
</rule>
Expand Down