Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows (and remove work-arounds) #183

Merged
merged 2 commits into from Jun 25, 2022
Merged

GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows (and remove work-arounds) #183

merged 2 commits into from Jun 25, 2022

Commits on Jun 24, 2022

  1. GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows 

    As discussed in 181.

Fixes 181
    @jrfnl
    jrfnl committed Jun 24, 2022
    Copy the full SHA
    9cf4da4 View commit details
    Browse the repository at this point in the history

  2. Tests: remove the TestCase::willPluginOutputShow() helper method an… 

    …d all uses

This method was put in place in PR 153 (commit d4f64b8) as a work-around for the problematic PHP 5.5 / Composer v1 on Windows build.

As we won't be running the tests against that particular combination anymore, I propose we remove all these work-arounds from the test suite.

This effectively reverts the following commits (and a little more):
* f0251b8.
* ccd127f.
* d4f64b8.
    @jrfnl
    jrfnl committed Jun 24, 2022
    Copy the full SHA
    3faa61e View commit details
    Browse the repository at this point in the history