Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename namespace prefix from Dealerdirect to PHPCSStandards #191

Merged
merged 1 commit into from Nov 2, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 3, 2022

Proposed Changes

As discussed in issue #188.

馃憠馃徎 Important: this needs a "breaking change" changelog entry as the command to run the plugin directly (either manually or via a script) has changed. See the README updates for the change which needs to be highlighted in the changelog.

Related Issues

Fixes #188

As discussed in issue 188.

**Important**: this needs a "breaking change" changelog entry as the command to run the plugin directly (either manually or via a script) has changed. See the README updates for the change which needs to be highlighted in the changelog.
@jrfnl jrfnl requested a review from a team October 3, 2022 13:26
@fredden
Copy link
Member

fredden commented Oct 3, 2022

Is changing the package name in composer.json in-scope for this, or will that be handled separately?

"name": "dealerdirect/phpcodesniffer-composer-installer",

@jrfnl
Copy link
Member Author

jrfnl commented Oct 3, 2022

Is changing the package name in composer.json in-scope for this, or will that be handled separately?

"name": "dealerdirect/phpcodesniffer-composer-installer",

@fredden Thanks for asking. Renaming the package is outside the scope of this PR and is being discussed in issue #159.
To be honest, as the impact on end-users of a package rename is HUGE, that probably won't happen.

Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked locally, could not find anything missing. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the namespace
3 participants