Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename references to master branch #199

Closed
wants to merge 1 commit into from

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jan 2, 2023

Proposed Changes

This PR is to be merged in conjunction with the branch rename to main as discussed in #160

Related Issues

Fixes #160

This PR is to be merged in conjunction with the branch rename to `main` as discussed in 160

Fixes 160
Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code, I didn't find other instances that the ones changed here.

The only other reference is https://github.com/PHPCSStandards/composer-installer/blob/master/tests/PHPCSVersions.php#L23 but if I understand correctly that is the branch on PHPCS not this project.

@jrfnl
Copy link
Member Author

jrfnl commented Jan 5, 2023

I've checked the code, I didn't find other instances that the ones changed here.

The only other reference is https://github.com/PHPCSStandards/composer-installer/blob/master/tests/PHPCSVersions.php#L23 but if I understand correctly that is the branch on PHPCS not this project.

100% correct. That's the PHPCS branch, not a reference to a branch in this project. Only thing we could do there, would maybe be to update line 19 to make it crystal clear that is a PHPCS branch reference:

* Composer name for the development branch.

@Potherca Potherca changed the base branch from master to main January 5, 2023 11:19
@Potherca Potherca marked this pull request as ready for review January 5, 2023 11:19
@Potherca Potherca deleted the branch main January 5, 2023 11:25
@Potherca Potherca closed this Jan 5, 2023
@Potherca Potherca deleted the feature/160-update-references-to-default-branch branch January 5, 2023 11:28
@Potherca
Copy link
Member

Potherca commented Jan 5, 2023

I have renamed branch master to main. These changes have been merged into main via #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open discussion: rename the default branch ?
2 participants