Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Travis: test builds against PHP 7.3 #62

Merged
merged 1 commit into from Oct 25, 2018
Merged

Build/Travis: test builds against PHP 7.3 #62

merged 1 commit into from Oct 25, 2018

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 14, 2018

Proposed Changes

Once PHP 7.3-beta came out, the nightly build on Travis became PHP 7.4-dev and build haven't been tested against PHP 7.3 for months now.

Luckily, Travis has finally deemed it appropriate to set up a PHP 7.3 alias now RC3 is out, so I've added PHP 7.3 to the matrix.

Related Issues

travis-ci/travis-ci#9717 (comment)

Once PHP 7.3-beta came out, the `nightly` build on Travis became PHP 7.4-dev and build haven't been tested against PHP 7.3 for months now.

Luckily, Travis has *finally* deemed it appropriate to set up a PHP 7.3 alias now RC3 is out, so I've added  PHP 7.3 to the matrix.
Copy link
Contributor

@mjrider mjrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@frenck frenck merged commit 40a8fa7 into PHPCSStandards:master Oct 25, 2018
@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

Thanks

@jrfnl jrfnl deleted the feature/travis-add-php-7.3 branch October 25, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants