Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS: fix compliance with PSR12 #88

Merged
merged 1 commit into from Dec 14, 2019
Merged

CS: fix compliance with PSR12 #88

merged 1 commit into from Dec 14, 2019

Commits on Dec 8, 2019

  1. CS: fix compliance with PSR12 

    PHPCS 3.5.0+ contains a far more complete PSR12 ruleset.

1. The current code didn't fully comply with that ruleset. Some minor code tweaks fix that.
2. PSR12 demands constant visibility to be declared, but as this project still supports PHP 5.3 and constant visibility wasn't introduced until PHP 7.1, this is not desirable. Excluding that particular rule from within the ruleset fixes that.
    @jrfnl
    jrfnl committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    b905338 View commit details
    Browse the repository at this point in the history