Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the installed_paths after save #97

Merged
merged 1 commit into from Jan 19, 2020
Merged

Verify the installed_paths after save #97

merged 1 commit into from Jan 19, 2020

Commits on Jan 19, 2020

  1. Verify the installed_paths after save 

    As most problems reported are to do with paths not being set correctly, let's verify success within the plugin, independently of PHPCS.

To that end, a new function `verifySaveSuccess()` has been added.
This function takes the paths which were to be saved and compares then to the paths which are actually set in PHPCS after the save to determine whether or not the plugin was successful and changes the exit code if this is not the case.

If there was a mismatch in paths and `verbose` mode is turned on, an information message will be displayed to help debugging.

At this moment I don't have a test case for this new functionality, however, I imagine it will come in useful with future bug reports.
    @jrfnl
    jrfnl committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    5277f67 View commit details
    Browse the repository at this point in the history