Commits on Jan 19, 2020

1. Bug fix: loadInstalledPaths() very very broken since PHPCS 3.1.0 …

   The PHPCS `--config-show` command shows **all** config settings set, not just the `installed_paths` and since PHPCS 3.1.0, it also includes a line to indicate which configuration file is being used to help with debugging configuration issues.
   
   In PHPCS 2.0 - 3.0.1, if any [other configuration options](https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options) were set, the result of the `loadInstalledPaths()` command would be broken.
   
   In PHPCS 3.1.0+, the result would always be broken, no matter what.
   
   In effect this means that the `installed_paths` would (nearly) always be set as if the config was previously non-existent as the `cleanInstalledPaths()` method would empty out the array as the values contained therein would be invalid anyway.
   
   It would be lovely if it were possible to add unit tests, but as we're talking about a `private` method setting a `private` property...
   
   So, for now, to proof the bug and validate the fix, I've set up a "fake" unit test to demonstrate what the previous behaviour was and what the behaviour will be with this fix in place: https://3v4l.org/XKMIf

   

   jrfnl committed Jan 19, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for b09c763
   • Browse repository at this point

   Copy the full SHA

   b09c763 View commit details

   Browse the repository at this point in the history