GH Actions: fix builds failing #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in the `shivammathur/setup-php@v2` has broken the handling of ini values passed via step output parameters. I have [reported this bug upstream](shivammathur/setup-php#405). For now, I'm fixing the build failures by commenting out the custom ini value setting. Once the upstream bug has been fixed, this commit should be reverted.
jrfnl
added
chores/QA
PR: quick merge
... as it the required statuses prevent those PRs from being merged without the required statuses reporting.
|
I have added a second commit to this PR. Nothing terribly exciting, just making sure that PR #1264 can be merged ;-) GHActions: don't ignore PRs with only doc changes... as it the required statuses prevent those PRs from being merged without the required statuses reporting. |
|
Wohoo! According to a response from the package author, the upstream bug should already be fixed... 🎉 I'm testing it now via another branch and will close this PR once the fix has been confirmed. |
Merged
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the
shivammathur/setup-php@v2has broken the handling of ini values passed via step output parameters.I have reported this bug upstream.
For now, I'm fixing the build failures by commenting out the custom ini value setting.
Once the upstream bug has been fixed, this commit should be reverted.