Adapting namespace sensitivity from pr (#1695) to issue (#1649) #1700
Conversation
There was a problem hiding this comment.
@rdss-sknott Hi Sebastian, thank you for submitting this follow-up PR.
Mostly looking good, though there are some copy/paste artifacts which need to be fixed.
I'm also a little concerned that the tests didn't fail on these.
PHPCompatibility/Tests/Interfaces/InternalInterfacesUsesUnitTest.inc
Outdated
Show resolved
Hide resolved
Hi @jrfnl. Thank you for considering this pull request. As last time I will go through you remarks and comment them in place and always: Thank you for your time and your great work! |
rdss-sknott
force-pushed
the
fix/InternalInterfacesSniff-false-positive-on-use
branch
2 times, most recently
from
8f8f14d
to
5bbd83f
Compare
…ue (PHPCompatibility#1649) * Make InternalInterfacesSniff namespace sensitive * Make NewInterfaceSniff namespace sensitive
rdss-sknott
force-pushed
the
fix/InternalInterfacesSniff-false-positive-on-use
branch
from
5bbd83f
to
84fa0c5
Compare
There was a problem hiding this comment.
@rdss-sknott Thank you for making those updates! All looks good to me and tests are failing when I undo the latest fixes, so that's all sorted too.
The only thing I still realized/noticed is that there are no tests covering the "this is not an import use statement" condition, but I'm fine with that being fixed-up in a future PR (also for the NewClasses sniff).
|
@rdss-sknott Fancy doing the last one left as well ? |
|
@jrfnl Thank you for all the work and effort you put into this project. You provide a valuable service to all of us PHP developers that is greatly appreciated. Like last time, it was a great pleasure to work with you. I'll take a look at |
|
@rdss-sknott The pleasure goes both ways.
I totally understand. Anything you can do is appreciated though. |
As Promised in (1695). This is connected to (#1649)