Various minor cs tweaks #1710
Open
Various minor cs tweaks #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 1357 which removed support for PHPCS 2.x from the base test case.
jrfnl
added
chores/QA
PR: quick merge
fredden
approved these changes
May 13, 2024
Agreed, but the Slevomat standard has a higher minimum PHP version, which means, we can't add it to our dependencies, so for now, a manual sweep up once in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up after some recent merges.
CS: various minor tweaks
CS/QA: use use statements
Follow up on #1357 which removed support for PHPCS 2.x from the base test case.
Docs: use FQN in docblocks