Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): 修改pnpm最新版升级到9.0造成的构建问题 #1214

Merged
merged 1 commit into from Apr 17, 2024

Conversation

ddadaal
Copy link
Member

@ddadaal ddadaal commented Apr 17, 2024

pnpm的最新版升级到了9.0,Lockfile版本从6.x更新到了9.x,pnpm老版本8.x不兼容9.x的lockfile。而现在在容器构建时,执行pnpm fetch时下载的pnpm为最新版9.0,而此时所使用的lockfile为6.x,新版本的pnpm会在执行pnpm fetch时把lockfile更新到最新的9.x版本,但是后面在执行后续的pnpm指令时使用的pnpm版本为老版本8.x,不兼容最新的lockfile。

由于 vercel/turbo#7993 问题,现在不能升级pnpm到最新的9.0版本。

此PR把package.json在执行pnpm fetch执行复制进了容器,使得执行pnpm fetch时所使用的pnpm版本为指定的版本而非最新版,保证lockfile不会意外改变。

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 8489761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Apr 17, 2024
@ddadaal ddadaal merged commit 0bd490d into master Apr 17, 2024
10 checks passed
@ddadaal ddadaal deleted the fix-pnpm-break branch April 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-ReviewRequested Code Review Requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant