-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⚙️ Refactor pattern code structure #2326
Conversation
…theme into feat/refactor-pattern-code
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Looks like the |
Which extensions are missing? |
Run: import { fileIcons } from './fileIcons';
const io = fileIcons.icons[220].fileNames?.join('\n');
console.log(io); Get:
|
@Airkro thanks a lot, no it was not on purpose to remove some patterns. I've restored it, so that it should cover all patterns now: fe98e7c. The reason for the refactoring was to make the code more self-explanatory and more explicit what kind of file names are used for each pattern. I know that the code looks a bit more comprehensive but I prefer it that way. |
These lines should be removed, they are not part of Cosmiconfig. vscode-material-icon-theme/src/icons/patterns/patterns.ts Lines 94 to 95 in bcc8288
|
We should add some test cases for |
Reduce amount of code and amount of logic to apply the patterns to the file icons.