Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable force-update in insta #1456

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

max-sixty
Copy link
Member

Expect it to fail on Windows but provides a test case

Expect it to fail on Windows but provides a test case
@max-sixty max-sixty marked this pull request as draft January 13, 2023 20:42
@max-sixty max-sixty mentioned this pull request Feb 1, 2023
@max-sixty
Copy link
Member Author

Expect it to fail on Windows but provides a test case

FYI this now passes because of https://github.com/PRQL/prql/pull/1456/files#diff-b73931d39044edca7c78f83713af7326a8d63dac151088b8d905e39f060ed8a6R69-R72, when removed it'll fail again

@max-sixty
Copy link
Member Author

Expect it to fail on Windows but provides a test case

FYI this now passes because of https://github.com/PRQL/prql/pull/1456/files#diff-b73931d39044edca7c78f83713af7326a8d63dac151088b8d905e39f060ed8a6R69-R72, when removed it'll fail again

Now upgraded to 1.28, removed this, and it passes!

@max-sixty
Copy link
Member Author

I think waiting to resolve mitsuhiko/insta#351 may make sense; otherwise folks may be getting large confusing diffs locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant