Save detection inference logs to file #12042
Conversation
|
Thanks for your contribution! |
|
|
| log_file = args.save_log_path | ||
| if os.path.isdir(args.save_log_path) or (not os.path.exists(args.save_log_path) and args.save_log_path.endswith("/")): | ||
| log_file = os.path.join(log_file, "benchmark_detection.log") | ||
| logger = get_logger(log_file=log_file) |
There was a problem hiding this comment.
seems this logger should be prepared and passed into AutoLog as a arg in https://github.com/PaddlePaddle/PaddleOCR/blob/main/tools/infer/predict_det.py#L168
I am worrying about maintenance of AutoLog module, it's been implemented in https://github.com/LDOUBLEV/AutoLog, and published to a server as documented here:
PaddleOCR/test_tipc/prepare.sh
Line 204 in 38c0c9e
I think this is only been used by a terminated tipc plan, we should redesign this feature, or deprecate this feature.
There was a problem hiding this comment.
I am worrying about maintenance of AutoLog module, it's been implemented in https://github.com/LDOUBLEV/AutoLog, and published to a server as documented here:
In this case PaddleOCR could implement its own logger, instead of using AutoLog.
I think that it's a little bit of a pity to have a feature to run benchmarks without the option to save the results to a file (and only seeing them on screen instead), therefore I think this feature would be very useful.
tools/infer/predict_det.py
Outdated
|
|
||
| class TextDetector(object): | ||
| def __init__(self, args): | ||
| def __init__(self, args, logger): |
There was a problem hiding this comment.
logger arg needs a default value None, the default behavior should be using logger from logger = get_logger().
otherwise, it will break this:
PaddleOCR/tools/infer/predict_system.py
Line 51 in 1569cfb
I added the possibility to save the detection logs to file.
The code was almost all there already, just some arguments weren't passed the right way in order to save the detection logs to file.
In case, we could also implement this feature for the other scripts in
tools/infer/.