Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]merge uapi paddleocr #12076

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

zhangyubo0722
Copy link
Collaborator

No description provided.

Copy link

paddle-bot bot commented May 8, 2024

Thanks for your contribution!

@jzhang533
Copy link
Collaborator

please submit your work to main branch.
and, what is uapi ?

I will convert it to draft, since it's wip.

@jzhang533 jzhang533 marked this pull request as draft May 9, 2024 05:06
@zhangyubo0722
Copy link
Collaborator Author

please submit your work to main branch. and, what is uapi ?

I will convert it to draft, since it's wip.

This PR needs to synchronize the internal changes of pdx to the open source repo. After communicating with PaddleOCR developers, we plan to merge it into the 2.6.1 branch. We hope that this PR will be merged as soon as possible. Thank you.

@cuicheng01 cuicheng01 marked this pull request as ready for review May 15, 2024 10:07
@jzhang533
Copy link
Collaborator

Merging this patch to release/2.6.1 is an urgent request by @cuicheng01 from Baidu. Sure, we can merge it.

It would be helpful if PR author and stakeholders can explain the following:

  • what's the future plan for release/2.6.1 branch? if it will be used for internal fixes, probably we should rename it to a meaningful branch name.
  • is this change related to paddlex ?
  • what is uapi ?

@jzhang533 jzhang533 merged commit dddf008 into PaddlePaddle:release/2.6.1 May 15, 2024
1 check passed
@GreatV
Copy link
Collaborator

GreatV commented May 16, 2024

Does this change require a cherry pick to the main branch?

@cuicheng01
Copy link
Collaborator

"release/2.6.1" is the stable branch of PaddleOCR for PaddleX dependencies. The new version of PaddleX will be open sourced at the end of May. This change is just a minor modification to the 2.6.1 branch that PaddleX previously relied on."uapi" is the core code of PaddleX.
We don't think it's necessary to update the main branch. Of course, we can listen to @jzhang533 's advice.

@jzhang533
Copy link
Collaborator

"release/2.6.1" is the stable branch of PaddleOCR for PaddleX dependencies. The new version of PaddleX will be open sourced at the end of May. This change is just a minor modification to the 2.6.1 branch that PaddleX previously relied on."uapi" is the core code of PaddleX. We don't think it's necessary to update the main branch. Of course, we can listen to @jzhang533 's advice.

Please keep in mind that this project has transitioned to being fully community-driven. Seeking consensus and clear public communication in the community is crucial for this new model.

@cuicheng01
Copy link
Collaborator

Please keep in mind that this project has transitioned to being fully community-driven. Seeking consensus and clear public communication in the community is crucial for this new model.

Alright, I understand. Thank you all for your remarkable work. As for the branch issue, we don't think the updates from this specific branch need to be cherry-pick to the main branch at this time. However, if anyone holds a different view, we can discuss it together. @GreatV

@GreatV
Copy link
Collaborator

GreatV commented May 24, 2024

@cuicheng01 Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants