[Experimental] Improve support for swizzling theme components #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +112 B (0%) Total Size: 4.17 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 9ea8403): https://docusaurus-openapi-36b86--pr351-gyq5puhh.web.app (expires Fri, 30 Dec 2022 19:54:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
5 tasks
|
Steps to swizzle Screen.Recording.2022-11-28.at.5.16.18.PM.movEnd result after inserting 🦝 after "Request":
|
|
Test swizzling Screen.Recording.2022-11-30.at.2.52.19.PM.mov |
blindaa121
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #246.
Previously, we were using relative paths to import/cross-reference theme components. Swizzling these components caused those import paths to break. The primary change is to instead import from
@themeand@theme/ApiDemoPanelrespectively.Motivation and Context
Allow support for swizzling and overriding theme components.
How Has This Been Tested?
Tested using the demo site. Swizzled the
Requestcomponent and overrode some text for testing. Will post screenshots later.