Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create list of 2xx content types for request samples #365

Merged
merged 6 commits into from Dec 16, 2022
Merged

Only create list of 2xx content types for request samples #365

merged 6 commits into from Dec 16, 2022

Conversation

csestito
Copy link
Collaborator

Description

For requests that had multiple content types not in the 2xx status range, we were allowing those content types in the accept header. Instead we should only show the options if there are multiple content types within the 2xx status'.

Motivation and Context

How Has This Been Tested?

Removed additional content type for Find pet by ID v2.0, ensured it only builds content from 2xx responses.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@csestito csestito closed this Dec 13, 2022
@csestito csestito reopened this Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Dec 13, 2022 •
edited

Size Change: +14.3 kB (0%)

Total Size: 4.16 MB

Filename Size Change
demo/build/assets/css/styles.********.css 108 kB +242 B (0%)
demo/build/assets/js/0d832478.********.js 26.7 kB +324 B (+1%)
demo/build/assets/js/12693653.********.js 26 kB +324 B (+1%)
demo/build/assets/js/1a8cc2a6.********.js 12.1 kB +54 B (0%)
demo/build/assets/js/1e6c5cae.********.js 35.2 kB +468 B (+1%)
demo/build/assets/js/1f818248.********.js 12.2 kB +36 B (0%)
demo/build/assets/js/3946f914.********.js 35 kB +468 B (+1%)
demo/build/assets/js/3e0d14e9.********.js 24.4 kB +198 B (+1%)
demo/build/assets/js/40a238b6.********.js 26 kB +324 B (+1%)
demo/build/assets/js/466ac800.********.js 44.6 kB +828 B (+2%)
demo/build/assets/js/4964e910.********.js 25.4 kB +324 B (+1%)
demo/build/assets/js/49bd3d39.********.js 17.6 kB +216 B (+1%)
demo/build/assets/js/4b891ed6.********.js 11.3 kB +36 B (0%)
demo/build/assets/js/4c5e977b.********.js 39.5 kB +55 B (0%)
demo/build/assets/js/57f1a671.********.js 11.4 kB +36 B (0%)
demo/build/assets/js/58ff8b1e.********.js 20.6 kB +54 B (0%)
demo/build/assets/js/63fc267d.********.js 11.3 kB +36 B (0%)
demo/build/assets/js/66c76a57.********.js 35.4 kB +468 B (+1%)
demo/build/assets/js/68b61ac5.********.js 44.8 kB +828 B (+2%)
demo/build/assets/js/69a61f78.********.js 25.8 kB +324 B (+1%)
demo/build/assets/js/73b594ee.********.js 35.1 kB +468 B (+1%)
demo/build/assets/js/77264a1a.********.js 34.9 kB +468 B (+1%)
demo/build/assets/js/7ca3ae45.********.js 17.6 kB +216 B (+1%)
demo/build/assets/js/7ed7dafe.********.js 26.7 kB +324 B (+1%)
demo/build/assets/js/86c45737.********.js 25.7 kB +198 B (+1%)
demo/build/assets/js/8961c7a6.********.js 25.1 kB +198 B (+1%)
demo/build/assets/js/91696e06.********.js 35.4 kB +468 B (+1%)
demo/build/assets/js/94589c06.********.js 20.1 kB +288 B (+1%)
demo/build/assets/js/97810f3c.********.js 25.6 kB +324 B (+1%)
demo/build/assets/js/9b5caaf3.********.js 25.9 kB +324 B (+1%)
demo/build/assets/js/9c42c0f3.********.js 34.4 kB +468 B (+1%)
demo/build/assets/js/a6cd895f.********.js 20.6 kB +54 B (0%)
demo/build/assets/js/aa2f1ec7.********.js 25.1 kB +198 B (+1%)
demo/build/assets/js/ab09fd5c.********.js 20.7 kB +54 B (0%)
demo/build/assets/js/ab6072f2.********.js 25.8 kB +324 B (+1%)
demo/build/assets/js/ae7f40a3.********.js 44.9 kB +828 B (+2%)
demo/build/assets/js/b4ebd305.********.js 17.6 kB +216 B (+1%)
demo/build/assets/js/b5c059ef.********.js 34.5 kB +468 B (+1%)
demo/build/assets/js/c65697f5.********.js 26.5 kB +324 B (+1%)
demo/build/assets/js/cf07762b.********.js 25.7 kB +198 B (+1%)
demo/build/assets/js/common.********.js 389 kB +194 B (0%)
demo/build/assets/js/dd696920.********.js 25.6 kB +324 B (+1%)
demo/build/assets/js/e015ccf9.********.js 25.9 kB +324 B (+1%)
demo/build/assets/js/eae14b71.********.js 34.2 kB +468 B (+1%)
demo/build/assets/js/eaf4471e.********.js 12 kB +54 B (0%)
demo/build/assets/js/f212caf7.********.js 25 kB +198 B (+1%)
demo/build/assets/js/f4486b6b.********.js 12 kB +54 B (0%)
demo/build/assets/js/f84e10c2.********.js 19.3 kB +288 B (+2%)
demo/build/assets/js/fe97f0d1.********.js 20.2 kB +288 B (+1%)
ℹ️ View Unchanged
Filename Size Change
demo/.docusaurus/globalData.json 18.6 kB 0 B
demo/build/assets/js/006e727e.********.js 13.9 kB 0 B
demo/build/assets/js/05f64ae1.********.js 2.81 kB 0 B
demo/build/assets/js/06b64fc1.********.js 575 B 0 B
demo/build/assets/js/06e5f0f0.********.js 27.4 kB +18 B (0%)
demo/build/assets/js/081bfb0d.********.js 9.92 kB 0 B
demo/build/assets/js/09e07b87.********.js 2.99 kB 0 B
demo/build/assets/js/14eb3368.********.js 9.26 kB 0 B
demo/build/assets/js/1639936b.********.js 7.65 kB 0 B
demo/build/assets/js/16577668.********.js 387 B 0 B
demo/build/assets/js/177e86db.********.js 10.8 kB 0 B
demo/build/assets/js/19d75775.********.js 8.72 kB 0 B
demo/build/assets/js/1a4e3797.********.js 77.6 kB 0 B
demo/build/assets/js/1be78505.********.js 10.6 kB 0 B
demo/build/assets/js/1c54f54e.********.js 10.7 kB 0 B
demo/build/assets/js/1e6ff21d.********.js 10.8 kB 0 B
demo/build/assets/js/2c860537.********.js 7.33 kB 0 B
demo/build/assets/js/3136173c.********.js 361 B 0 B
demo/build/assets/js/326c3861.********.js 13.4 kB 0 B
demo/build/assets/js/3720c009.********.js 1.44 kB 0 B
demo/build/assets/js/3893.********.js 1.07 kB 0 B
demo/build/assets/js/39d00f16.********.js 13.4 kB 0 B
demo/build/assets/js/41cd56a1.********.js 10.2 kB 0 B
demo/build/assets/js/423cd203.********.js 13.8 kB 0 B
demo/build/assets/js/4261.********.js 463 B 0 B
demo/build/assets/js/4670.********.js 104 B 0 B
demo/build/assets/js/46afcded.********.js 8.21 kB 0 B
demo/build/assets/js/46e5c6ac.********.js 6.86 kB 0 B
demo/build/assets/js/47abaca6.********.js 2.91 kB 0 B
demo/build/assets/js/4935.********.js 1.05 kB 0 B
demo/build/assets/js/4965.********.js 1.33 MB 0 B
demo/build/assets/js/4b901b1a.********.js 350 B 0 B
demo/build/assets/js/55960ee5.********.js 383 B 0 B
demo/build/assets/js/55a6d13f.********.js 13.8 kB 0 B
demo/build/assets/js/56717cba.********.js 2.97 kB 0 B
demo/build/assets/js/597ddc40.********.js 10.5 kB 0 B
demo/build/assets/js/5fb917be.********.js 2.56 kB 0 B
demo/build/assets/js/6a105426.********.js 354 B 0 B
demo/build/assets/js/8003.********.js 5.45 kB 0 B
demo/build/assets/js/85d3c400.********.js 2.9 kB 0 B
demo/build/assets/js/85ec4403.********.js 4.67 kB 0 B
demo/build/assets/js/86b273b1.********.js 10.5 kB 0 B
demo/build/assets/js/86c346b0.********.js 538 B 0 B
demo/build/assets/js/8777.********.js 76.5 kB 0 B
demo/build/assets/js/881db345.********.js 394 B 0 B
demo/build/assets/js/8ab9b16e.********.js 9.95 kB 0 B
demo/build/assets/js/8d4e78cd.********.js 2.83 kB 0 B
demo/build/assets/js/8f36b2a3.********.js 172 B 0 B
demo/build/assets/js/8f441c78.********.js 13.3 kB 0 B
demo/build/assets/js/9127.********.js 104 B 0 B
demo/build/assets/js/93304a97.********.js 7.77 kB 0 B
demo/build/assets/js/935f2afb.********.js 33 kB 0 B
demo/build/assets/js/967247e2.********.js 8.71 kB 0 B
demo/build/assets/js/a40c6d71.********.js 8.61 kB 0 B
demo/build/assets/js/a476e24e.********.js 344 B 0 B
demo/build/assets/js/a5491aaa.********.js 400 B 0 B
demo/build/assets/js/a728d93a.********.js 9.99 kB 0 B
demo/build/assets/js/bead4b8e.********.js 3.04 kB 0 B
demo/build/assets/js/bf271e74.********.js 401 B 0 B
demo/build/assets/js/c5644638.********.js 337 B 0 B
demo/build/assets/js/c7a5be9f.********.js 10.2 kB 0 B
demo/build/assets/js/c7ded1cb.********.js 2.95 kB 0 B
demo/build/assets/js/cef3f2e2.********.js 5.8 kB 0 B
demo/build/assets/js/d63c7029.********.js 2.92 kB 0 B
demo/build/assets/js/df203c0f.********.js 1.8 kB 0 B
demo/build/assets/js/e01f8d18.********.js 8.69 kB 0 B
demo/build/assets/js/e2ce9793.********.js 402 B 0 B
demo/build/assets/js/e5e5340c.********.js 2.48 kB 0 B
demo/build/assets/js/e8b309fb.********.js 577 B 0 B
demo/build/assets/js/ecc39b49.********.js 172 B 0 B
demo/build/assets/js/ee308fa3.********.js 10.1 kB 0 B
demo/build/assets/js/f65290a6.********.js 10.5 kB 0 B
demo/build/assets/js/f8409a7e.********.js 34.3 kB 0 B
demo/build/assets/js/main.********.js 406 kB 0 B
demo/build/assets/js/runtime~main.********.js 8.95 kB 0 B
demo/build/index.html 89.3 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Dec 13, 2022 •
edited

Visit the preview URL for this PR (updated for commit e464c7f):

https://docusaurus-openapi-36b86--pr365-1muz29sq.web.app

(expires Sun, 15 Jan 2023 14:58:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

sserrata
sserrata approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would prefer to postpone including the "test" API until we:

  • Determine test cases we want to cover
  • Can deploy the API such that it's able to handle real requests

@csestito csestito merged commit 8f3f511 into main Dec 16, 2022
@sserrata sserrata deleted the accept-headers branch December 16, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sserrata sserrata sserrata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csestito @sserrata