Only create list of 2xx content types for request samples #365
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +14.3 kB (0%) Total Size: 4.16 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit e464c7f): https://docusaurus-openapi-36b86--pr365-1muz29sq.web.app (expires Sun, 15 Jan 2023 14:58:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
reviewed
Dec 14, 2022
packages/docusaurus-theme-openapi-docs/src/theme/ApiItem/index.tsx
Outdated
Show resolved
Hide resolved
csestito
force-pushed
the
accept-headers
branch
from
e10c2fa to
60aa7f9
Compare
sserrata
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For requests that had multiple content types not in the 2xx status range, we were allowing those content types in the accept header. Instead we should only show the options if there are multiple content types within the 2xx status'.
Motivation and Context
How Has This Been Tested?
Removed additional content type for Find pet by ID v2.0, ensured it only builds content from 2xx responses.
Screenshots (if appropriate)
Types of changes
Checklist