Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolveInternal to swagger2openapi options #375

Merged
merged 2 commits into from Jan 2, 2023

Conversation

gustavste
Copy link
Contributor

Description

Adding resolveInternal option when using swagger2openapi to convert Swagger 2.0 to oapi3.

Motivation and Context

Some $ref doesn't seem to get resolved without it.
#372

How Has This Been Tested?

After adding this option i ran the gen-commands and all $refs seemed to have been resolved. The generated docs looked as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@github-actions
Copy link

github-actions bot commented Dec 28, 2022

Visit the preview URL for this PR (updated for commit 2154964):

https://docusaurus-openapi-36b86--pr375-ki7481om.web.app

(expires Fri, 27 Jan 2023 20:02:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata
Copy link
Member

Hi @gustavste, thanks for the PR. Can you run yarn format --fix to address the linter issues?

Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@sserrata sserrata merged commit 659ded9 into PaloAltoNetworks:main Jan 2, 2023
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants