Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sass-loader module as dependency #639

Merged

Conversation

Mikescops
Copy link
Contributor

Description

sass-loader was used from a sub-dependency but called directly in the module

Motivation and Context

Fix #638

How Has This Been Tested?

Tested on a project that uses pnpm8 as package manager. The build passes when it used to not pass.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Sorry, something went wrong.

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

Verified

This commit was signed with the committer’s verified signature.
@Mikescops Mikescops force-pushed the bugfix/sass-loader-as-dependency branch from 2364371 to d966874 Compare October 9, 2023 16:13
@sserrata sserrata requested a review from blindaa121 October 12, 2023 13:12
@blindaa121
Copy link
Collaborator

Hi @Mikescops, would you also be able to confirm that this works with yarn as well?

@Mikescops
Copy link
Contributor Author

Hi @Mikescops, would you also be able to confirm that this works with yarn as well?

Yes i just checked again with the demo project and it works.

image

Verified

This commit was signed with the committer’s verified signature.
@Mikescops Mikescops temporarily deployed to default October 17, 2023 07:09 — with GitHub Actions Inactive
@Mikescops
Copy link
Contributor Author

I forgot the lockfile, just added it now.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ad70b24):

https://docusaurus-openapi-36b86--pr639-g4wb17to.web.app

(expires Thu, 16 Nov 2023 16:21:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@blindaa121 blindaa121 merged commit 46ee070 into PaloAltoNetworks:v2.0.0 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants