Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react nextui dependency in v2.0.0 #641

Merged

Conversation

Mikescops
Copy link
Contributor

Description

This is a suggestion to fix bugs and avoid loading large library.

Remove NextUI library from v2.0.0.

Motivation and Context

NextUI is a giant library and it's only used to display a loader that can be used in simpler way.

This dependency was creating side effects that weren't resolved: #608

How Has This Been Tested?

This was tested with the demo and a side project, using both Yarn and PNPM8.

Screenshots (if appropriate)

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Mikescops Mikescops temporarily deployed to default October 9, 2023 16:23 — with GitHub Actions Inactive
@Mikescops
Copy link
Contributor Author

Either we remove it, or we bump the dependency to its latest version (here it was using the beta).

Note: Loading is probably now named Spinner: https://nextui.org/docs/components/spinner

@sserrata sserrata requested a review from blindaa121 October 12, 2023 13:13
@sserrata
Copy link
Member

Hi @Mikescops, thanks for the suggestion/tip. I agree that there are other ways to render a loading spinner without depending on large libraries. We'll look into refactoring it.

@Mikescops
Copy link
Contributor Author

Hi @Mikescops, thanks for the suggestion/tip. I agree that there are other ways to render a loading spinner without depending on large libraries. We'll look into refactoring it.

Thanks @sserrata feel free to reuse this PR or create new one/delete this one.

@Mikescops
Copy link
Contributor Author

@sserrata Should this be merged now that it's approved?

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Visit the preview URL for this PR (updated for commit c504f00):

https://docusaurus-openapi-36b86--pr641-4onbh8xz.web.app

(expires Thu, 16 Nov 2023 16:43:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sserrata sserrata merged commit 62c9442 into PaloAltoNetworks:v2.0.0 Oct 17, 2023
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants