feat(api,proxy): Add events for server registration/un-registration #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These events are useful in the case of running velocity inside a k3s cluster.
powercasgamer
suggested changes
Aug 1, 2023
api/src/main/java/com/velocitypowered/api/event/proxy/ServerRegisteredEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/proxy/ServerUnRegisteredEvent.java
Outdated
Show resolved
Hide resolved
powercasgamer
suggested changes
Aug 1, 2023
| import com.velocitypowered.api.proxy.server.ServerInfo; | ||
|
|
||
| /** | ||
| * This event is fired by the proxy after a new backend server is registered |
There was a problem hiding this comment.
This should probably explain a bit more of what "registered" means
There was a problem hiding this comment.
"registered" means adding a new backend server to the proxy dynamically at runtime.
Will this do?
There was a problem hiding this comment.
Maybe add a
@see ProxyServer.html#registerServer(com.velocitypowered.api.proxy.server.ServerInfo)obviously format it right for the javadoc
| import com.velocitypowered.api.proxy.server.ServerInfo; | ||
|
|
||
| /** | ||
| * This event is fired by the proxy before a backend server is unregistered |
| /** | ||
| * This event is fired by the proxy before a backend server is unregistered | ||
| */ | ||
| public class ServerUnRegisteredEvent { |
There was a problem hiding this comment.
Not a fan of this name personally, specifically the "UnRegistered" part
There was a problem hiding this comment.
Do you have any suggestions for what the name should be?
4drian3d
reviewed
Aug 1, 2023
proxy/src/main/java/com/velocitypowered/proxy/server/ServerMap.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These events are useful in the case of running velocity inside a k3s cluster.