Use the default Minecraft port instead of custom one #1277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Velocity uses the custom port
25577
in its default config which does not make any sense for 99.9% of deployments and has caused confusion and unnecessary support requests time and time again without any obvious benefit as usually you want the proxy to be reachable instead of your normal servers which wouldn't even be usable anymore as soon as you enable proxy support on the Minecraft server. (I kinda assume this was originally just copied from Bungee's default being 25577)While a non-standard port can be useful for testing in some situations when already having a Minecraft server running in others it might actually be decremental (e.g. because you need to add another server into your server list instead of just using one localhost with port 25565). For cases where this behaviour is desired a custom port can always be specified in the config anyways.
Existing setups should not get influenced by this change as they already have a config with the value and even in a case where a container image is used which relies on a specific port this change should not cause any issues as the config should either be persisted or be part of the container image if it is setup right. (e.g. like how the Velocity Pterodactyl egg does it)
And if there was discussion/issues/PRs open for that before then I'm sorry but I couldn't find them...