feat: Add information about 1.20.5 changes to internals to nms guide #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leguan16
changed the title
powercasgamer
suggested changes
May 4, 2024
zlataovce
reviewed
May 4, 2024
| @@ -93,7 +107,6 @@ int dataVersion = Bukkit.getUnsafe().getDataVersion(); | |||
|
|
|||
| :::danger[Parsing the version] | |||
|
|
|||
| You should not parse the version from the package name of classes. This is because CraftBukkit may not be relocated | |||
| in the future. | |||
| Parsing the version from the package name of classes is no longer possible as of 1.20.5 as Paper stopped relocating the CraftBukkit package. See the [reflection](#reflection) section for more information. | |||
There was a problem hiding this comment.
Suggested change
| Parsing the version from the package name of classes is no longer possible as of 1.20.5 as Paper stopped relocating the CraftBukkit package. See the [reflection](#reflection) section for more information. | |
| Parsing the version from the package name of classes is no longer possible as of 1.20.5 as Paper stopped relocating the CraftBukkit package. See the [Reflection](#reflection) section for more information. |
There was a problem hiding this comment.
why exactly just here? nvm
There was a problem hiding this comment.
it's the name of the section
There was a problem hiding this comment.
eh, its not really done at other places either.
zlataovce
reviewed
May 4, 2024
| :::info[Mojang-mapped runtime as of 1.20.5] | ||
|
|
||
| As of 1.20.5, Paper ships with a Mojang-mapped runtime instead of reobfuscating the server to Spigot mappings. | ||
| For more information, see the [plugin remapping](./project-setup#plugin-remapping) section and [userdev](./userdev#1205) documentation covering these changes. |
There was a problem hiding this comment.
Suggested change
| For more information, see the [plugin remapping](./project-setup#plugin-remapping) section and [userdev](./userdev#1205) documentation covering these changes. | |
| For more information, see the [Plugin remapping](./project-setup#plugin-remapping) section and [userdev](./userdev#1205) documentation covering these changes. |
Machine-Maker
requested changes
May 13, 2024
|
|
ah yeah lol |
fixed xd |
olijeffers0n
approved these changes
May 13, 2024
Machine-Maker
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure if I should rewrite rather than only adding admonitions. If I should do it lmk.