Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type mismatch GraphQL #6151

Merged
merged 3 commits into from Mar 16, 2022
Merged

Fix type mismatch GraphQL #6151

merged 3 commits into from Mar 16, 2022

Conversation

tianrunhe
Copy link
Contributor

Fixed #5644

@tianrunhe tianrunhe requested review from Dschoordsch and removed request for Dschoordsch March 2, 2022 22:13
@mattkrick
Copy link
Member

This is caused by a bug in GraphQL.
It was fixed in v16 graphql/graphql-js#3328
We're still pinned on v15 because our version of relay is old.
I recommend the following:

  • Check to see if the latest version of relay supports graphql v16
  • bump to the latest version of relay & latest version of graphql in a separate PR
  • come back to this PR & amend it with the fixed typings

@tianrunhe
Copy link
Contributor Author

tianrunhe commented Mar 4, 2022 •
edited

This is caused by a bug in GraphQL. It was fixed in v16 graphql/graphql-js#3328 We're still pinned on v15 because our version of relay is old. I recommend the following:

  • Check to see if the latest version of relay supports graphql v16
  • bump to the latest version of relay & latest version of graphql in a separate PR
  • come back to this PR & amend it with the fixed typings

Looks like the latest relay v13.1.1 only supports to GraphQL v15.3.0

@Dschoordsch
Copy link
Contributor

Did some smoke tests (creating team, creating reflection, updating team name and add task due date) and still works.

@mattkrick
Copy link
Member

ah such a bummer about relay!
Looks like it was working in their RC facebook/relay#3705, but maybe it didn't land in the official release?

@mattkrick
Copy link
Member

LGTM

@mattkrick mattkrick merged commit c906883 into master Mar 16, 2022
@mattkrick mattkrick deleted the chore/5644/mismatch_graphql_types branch March 16, 2022 22:24
@adaniels-parabol adaniels-parabol mentioned this pull request Mar 25, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch approved these changes

@mattkrick mattkrick Awaiting requested review from mattkrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type mismatch GraphQL - Typescript
3 participants
@tianrunhe @mattkrick @Dschoordsch