WIP: Thredds download function #2458
Conversation
bailsofhay
added
Status: in progress
Topic: models - SIPNET
Priority: 01 - Low
Topic: Testing
Topic: New Dataset
Topic: Modules
|
@ankurdesai I had to remove the earlier PR I made last week with the SDA file changes attached. this is the new PR for the same Thredds function, but without non-related file changes. |
|
Turns out there was already a branch named thredds that was messing up my pr....... :/ |
There was a problem hiding this comment.
I see that this is still WIP so I hope my review isn't premature, but a few interface-level comments that are probably easier to address sooner rather than later.
Might also be useful to add a fully updated example that can double as a test case while you're working on the details.
| run_parallel = TRUE) { | ||
| # require("XML") | ||
| # require("RCurl") | ||
| require("foreach") |
There was a problem hiding this comment.
Functions should never explicitly load other packages. If it's not possible to call everything in namespaced form (foreach::fn_name(...)), consider formally importing the functions you need from foreach.
|
Once merged this will close #2415, correct? |
|
@infotroph, @ashiklom or @mdietze. What is the standard way to code in warnings. For example, I want a warning to pop up and kill data extraction if the user puts in a date range that the data doesn't exist during. |
|
Warning, errors, and logs should be handled through the logger functions in the PEcAn.utils package |
|
This PR is stale because it has been open 365 days with no activity. |
This function is the start of a general function that should be able to download data from THREDDS.
Description
The user can download any THREDDS datasets as long as they have site information, dates, and the base URLS needed to grab the datasets. Base URLS need the dataset name, but not the dates or locations. There will likely be issues pulling data sets in the future since they are not all stored in similarly structured directory formats like AVHRR LAI (which this function is based on). Updates to the function will occur as we start playing with more datasets from THREDDS.
Motivation and Context
We need an easy way to grab more datasets and THREDDS has many already, and is a great place to store future datasets that we can use.
Review Time Estimate
Types of changes
Checklist: