-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates of fates model #3233
base: develop
Are you sure you want to change the base?
Updates of fates model #3233
Conversation
edit sm, origin in as.POSIXlt F, units of time
model2netcdf.FATES.R updates
@Hhh-hyc Yucong congratulations on your first PEcAn PR, thank you for contributing. Let's iterate with the suggested revisions. |
out$dat[[i]] <- dat.new | ||
} | ||
library(ncdf4.helpers) # dims names | ||
model2netcdf.FATES <- function(outdir, sitelat, sitelon, pfts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Arguments to the function don't match the arguments in the documentation.
- Not sure why these new additional arguments are needed. Generally you want to convert ALL of the variables you can from a model run into PEcAn standard, and then select any subset of info you need when you read the PEcAn netCDF files (e.g. specific PFTs, variables, and locations)
@Hhh-hyc wanted to ping you about finishing up this PR, which has been in the queue for a while |
|
@Hhh-hyc checking in again on this PR which seems to require fairly minor changes to pass the GH Action checks. Is this something you'll be able to get back to soon? |
Description
Changes made in this pull request:
Motivation and Context
Integrate the newest version of CTSM-FATES into PEcAn. CTSM-FATES is assumed to be run in a docker or openshift container. The work is relevant to the issue on PEcAN #1008 and the issue on FATES: NGEET/fates#364
Review Time Estimate
Types of changes
Checklist: