Basgra updates including the YASSO SOC model #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 3, 2023 15:00
…to basgra-yasso
…e from initialize subroutine
…to basgra-yasso
…to basgra-yasso
…bles work with YASSO
…to basgra-yasso Conflicts: models/basgra/R/run_tests.R
…to basgra-yasso
…culate the tendencies due to decomposition. This simplifies the previously buggy flow of computation for plant to soil fluxes
…ecan into basgra-yasso-nitrogen
istfer
reviewed
Feb 26, 2024
|
Sorry for the long wait on this. @istfer @juliusvira is this ready to merge as soon as tests pass? |
infotroph
reviewed
May 8, 2024
There was a problem hiding this comment.
I started a comment about how these 12-MB IC files were too big for an R package, but on testing they compress remarkably well -- the entire PEcAn.BASGRA_1.7.2.tar.gz after this PR is still only 118 KB! So I think there's no action needed.
If need to maintain R 3.x compatibility, convert `*pr1(label, -1, var)` to `*pr(label,-1, array_containing_var, 1)`
|
@juliusvira @istfer would love to get this PR in. It appears that @infotroph has submitted a PR to @juliusvira branch of pecan with some fixes that should resolve the GH Actions warnings. Could you pull that in? That should update this PR and then we should be good to go! |
…te-note [Yasso] resolve check NOTE about fortran write()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new soil organic carbon (SOC) model to the BASGRA grassland model, updates the wrappers, and adds unit tests for the wrappers. The SOC model is an adaptation of the YASSO20 (https://doi.org/10.5194/gmd-15-1735-2022); the user can switch between YASSO20 and the original BASGRA_N SOC model by setting a parameter. The YASSO implementation also includes an experimental nitrogen cycling extension, which can be optionally enabled.
Motivation and Context
The modifications to BASGRA provide an option to choose a more detailed SOC model when needed.
Review Time Estimate
Types of changes
Checklist: