Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core vs posix gh 16163 20240505 #22197

Merged
merged 2 commits into from
May 23, 2024

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented May 5, 2024

This pull request should (a) complete the documentation advised in #16163; (b) provide tests to exercise that documentation. Since this is non-urgent and may take some time to double-check, I'm going to label it 'defer-next-dev' -- but we can begin code review now. Thanks.

As we did in bda53d3, update description of these POSIX functions to
reflect the fact that they differ from the corresponding builtin
functions in that they require an explicit argument, i.e., they cannot
reply on an implicit $_.

Add tests to exercise this property in t/usage.t.

For: GH Perl#16163 (partial)
POSIX::umask(), unlike the builtin umask(), cannot rely upon an implicit
$_.  It needs an explicit argument when being called.

For: GH Perl#16163 (now complete)
@jkeenan jkeenan added documentation POSIX defer-next-dev This PR should not be merged yet, but await the next development cycle labels May 5, 2024
@book book removed the defer-next-dev This PR should not be merged yet, but await the next development cycle label May 23, 2024
@book book merged commit cf9d355 into Perl:blead May 23, 2024
30 checks passed
@jkeenan jkeenan deleted the core-vs-posix-gh-16163-20240505 branch May 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants